Proposals / #853

Resolve the Mac PATH_HasReachedTarget return to full Boolean

applied · by Commit-Will · submitted 2026-11-02, applied 2026-11-02

Ghidra vmac 111 · 3cfe190

The complete Mac helper explicitly returns full EAX0/1, and its sole caller tests that result as a predicate. Resolve only the unknown four-byte return to the existing four-byte BOOL type. Preserve the already precise Unit input, chosen names, one Stack4 slot, locals and cdecl. Original Windows code verifies the same null-path/target-distance/coordinate branches and already has BOOL; both selected MODULE names match. Current native path/target producers establish the records. No rename, shared field/layout, helper/caller, guard or runtime/build change.

Changes 1, applied together

1. Set prototype mac 0x001842fb

   signatureundefined4 PATH_HasReachedTarget(D2UnitStrc * pUnit)→BOOL PATH_HasReachedTarget(D2UnitStrc * pUnit)
   convention__cdecl