Proposals / #857

Type Mac stat and skill button hit-test results as Boolean

applied · by Commit-Will · submitted 2026-11-02, applied 2026-11-02

Ghidra vmac 111 · 3cfe190

Both existing Mac UI hit-test helpers have four-byte undefined4 results. Their complete native bodies explicitly produce only0/1: every reaching CL value is XOR-zero or SETG, then full MOVZX EAX,CL reaches the sole RET. All8 incoming runtime calls immediately TEST fullEAX and use Boolean branches/normalization. Use existing4-byte BOOL, preserving chosen names, every existing int32_t argument/name, all3Stack4/8/c slots and cdecl. Complete target/caller native regions3208bytes independently match separate assembly; all9 CFGs, sole-return definitions, all refs and8 three-DWORD call setups verified. Incomplete mouse producer metadata stays opaque and unchanged; no pointer/layout/viewport enum or geometry extent inferred. No renames, Windows pairing/ABI import, source/global/helper/caller edits, incidental-return inference, runtime/build claim or reduced replacement of any withdrawn whole claim.

Changes 2, applied together

1. Set prototype mac 0x000bf533

   signatureundefined4 UI_IsMouseOnStatButton(int32_t nPanelMode, int32_t nMouseX, int32_t nMouseY)→BOOL UI_IsMouseOnStatButton(int32_t nPanelMode, int32_t nMouseX, int32_t nMouseY)
   convention__cdecl

2. Set prototype mac 0x000bf5f9

   signatureundefined4 UI_IsMouseOnSkillButton(int32_t nPanelMode, int32_t nMouseX, int32_t nMouseY)→BOOL UI_IsMouseOnSkillButton(int32_t nPanelMode, int32_t nMouseX, int32_t nMouseY)
   convention__cdecl