Proposals / #917

Type the Mac menu-connect flag getter as a full Boolean

applied · by Commit-Will · submitted 2026-11-02, applied 2026-11-02

Ghidra vmac 111 · 3cfe190

The complete Mac getter zero-extends the actual menu-connect byte into full EAX. Its three known explicit writers independently resolve their own PIC bases to that exact byte and store only1/0/0; the initial BSS state is zero. All four actual callers immediately TEST full EAX. Resolve undefined4 to existing four-byte BOOL, preserving chosen name, zero formals, cdecl and all other metadata. The original Windows getter already returns BOOL from the corresponding state circuit, with the same three literal writes and wait-button identifiers. No global type/width/name, callback, helper, shared interface or behavior change.

Changes 1, applied together

1. Set prototype mac 0x002c40f5

   signatureundefined4 MAINMENU_GetGlobalValue2(void)→BOOL MAINMENU_GetGlobalValue2(void)
   convention__cdecl