Proposals / #987

gnChannelUserListScrollOffset (0x00798f44) is a signed int: the visible-row window uses JL/JGE

applied · by Niehztog · submitted 2026-11-02, applied 2026-11-02

Ghidra v1846 · 4ca0e98

The scroll offset of the channel user list is undefined4 (emitted as uint32_t). COMCALLBACK_UpdateChannelUserList tests whether a user's row falls into the eleven visible rows starting at the offset, signed on both sides: 00447cd3 MOV EAX,[0x00798f44]; 00447cd8 CMP ECX,EAX; 00447cda JL; 00447ce0 ADD EAX,0xb; 00447ce3 CMP ECX,EAX; 00447ce5 JGE. An unsigned offset turns the comparison unsigned (JB/JAE). Recompiled with VC8 SP1 (oracle, tree 3dba660), the JGE at 00447ce5 comes out as the original's; no function lost.

Changes 1, applied together

1. Retype global win 0x00798f44

   typeundefined4 (4 bytes)→int