Proposals / #988

gpHireHoverUnit (0x007beed4) is a signed int: an X coordinate the mouse is tested against with JL/JG

applied · by Niehztog · submitted 2026-11-02, applied 2026-11-02

Ghidra v1846 · 4ca0e98

The global is undefined4 (emitted as uint32_t) and is no pointer: both hireling input handlers test the mouse X against it and against it + 0x2e, signed. INPUT_HireableHireClick: 00493708 MOV ECX,[0x007beed4]; 0049370e CMP EAX,ECX; 00493710 JL; 00493712 ADD ECX,0x2e; 00493715 CMP EAX,ECX; 00493717 JG. INPUT_HireableLongPress: 0049390f MOV ECX,[0x007beed4]; 00493915 CMP EAX,ECX; 00493917 JL; 0049391d ADD ECX,0x2e; 00493920 CMP EAX,ECX; 00493922 JG. It is the left edge of the 0x2e-wide hireling icon, beside gnHireIconDrawX (0x007beed8). Unsigned, VC8 emits JB/JA. Recompiled with VC8 SP1 (oracle, tree 3dba660), the four jumps come out as the original's; no function lost. Only the type changes; the name is a chosen one.

Changes 1, applied together

1. Retype global win 0x007beed4

   typeundefined4 (4 bytes)→int